Skip to content

feat(linux/kwin): log object serial when available on stream creation#5299

Merged
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
Kishi85:kwingrab-update-object-serial-logging
Jun 23, 2026
Merged

feat(linux/kwin): log object serial when available on stream creation#5299
ReenigneArcher merged 1 commit into
LizardByte:masterfrom
Kishi85:kwingrab-update-object-serial-logging

Conversation

@Kishi85

@Kishi85 Kishi85 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Log the pipewire object serial as well as the node when a valid one is received from KDE's screencasting wayland extension to be consistent with other debug logging.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85 Kishi85 force-pushed the kwingrab-update-object-serial-logging branch 2 times, most recently from a760475 to d418a27 Compare June 19, 2026 04:31
@Kishi85 Kishi85 changed the title feat(linux/kwin): update stream create log message with object serial feat(linux/kwin): log object serial when available on stream creation Jun 19, 2026
@Kishi85 Kishi85 force-pushed the kwingrab-update-object-serial-logging branch from d418a27 to 3ada381 Compare June 20, 2026 11:14
@ReenigneArcher ReenigneArcher added this to the pipewire milestone Jun 23, 2026
@ReenigneArcher ReenigneArcher force-pushed the kwingrab-update-object-serial-logging branch from 3ada381 to ca85f9c Compare June 23, 2026 13:59
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.85%. Comparing base (2438a9b) to head (ca85f9c).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/platform/linux/kwingrab.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5299      +/-   ##
==========================================
- Coverage   17.85%   17.85%   -0.01%     
==========================================
  Files         111      111              
  Lines       24602    24605       +3     
  Branches    10892    10894       +2     
==========================================
  Hits         4393     4393              
+ Misses      17674    16819     -855     
- Partials     2535     3393     +858     
Flag Coverage Δ
Archlinux 11.18% <0.00%> (-0.01%) ⬇️
FreeBSD-amd64 13.23% <0.00%> (+<0.01%) ⬆️
Homebrew-ubuntu-24.04 13.22% <0.00%> (-0.01%) ⬇️
Linux-AppImage 12.11% <0.00%> (-0.01%) ⬇️
Windows-AMD64 14.91% <ø> (ø)
Windows-ARM64 13.18% <ø> (-0.03%) ⬇️
macOS-arm64 19.13% <ø> (ø)
macOS-x86_64 18.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/kwingrab.cpp 0.00% <0.00%> (ø)

... and 51 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2438a9b...ca85f9c. Read the comment docs.

@ReenigneArcher ReenigneArcher merged commit fdf1363 into LizardByte:master Jun 23, 2026
58 of 60 checks passed
@sonarqubecloud

Copy link
Copy Markdown

vindeckyy pushed a commit to vindeckyy/Solar-Flare that referenced this pull request Jun 27, 2026
vindeckyy added a commit to vindeckyy/Solar-Flare that referenced this pull request Jun 27, 2026
…ted patch

Third round of fork improvements on top of the branding/CI work:

* docs/CHANGELOG-SolarFlare.md (145 lines). Fork-specific changelog
  separate from upstream's docs/changelog.md. Enumerates every fork
  change (config plumbing, branding, web UI, build script, docs,
  cherry-picked upstream commits) in the unreleased section. Cross-
  references docs/PORTING.md, docs/CONFIGURATION.md, README.md and
  PUSH-INSTRUCTIONS.md.

* scripts/cachyos-build.sh post-install verification. After the
  'Install + verification' step, the script now:
    1. Verifies the installed sunshine binary contains the fork
       banner ('Fork: SolarFlare') -- catches the case where a
       leftover upstream package overwrote the fork install.
    2. Writes a 5-key test config to /tmp, runs 'sunshine <conf>'
       for 1 second, and checks that all 5 fork keys appear in the
       parse log without any 'Unrecognized' warnings.
  Both checks are non-fatal warnings (so the script still succeeds
  if sunshine isn't on $PATH or the binary is older than the
  source), but they're loud enough that 'I just installed the
  fork and a key isn't taking effect' is now a clearly printed
  warning instead of a silent runtime surprise.
  Also updated the post-install Done banner to identify the binary
  as 'SolarFlare' and surface the 5 fork tunables (was 'Sunshine').

* Regenerated cachyos-fastpath.patch against upstream base commit
  1fce18d, including the cumulative fork changes (config keys,
  branding macro). Was 420 lines / 7 files / +280/-2; now 569 lines
  / 7 files / +379/-2. Verified to apply cleanly to a fresh clone
  of LizardByte/Sunshine HEAD with 3-way merge for upstream's own
  changes to pipewire.cpp / stream.cpp since the fork base.

* PUSH-INSTRUCTIONS.md updated to:
    - Reflect the new patch stats (+379/-2, was +280/-2).
    - Show the regeneration command for both the cumulative patch
      (git diff 1fce18d..HEAD) and the historical patch
      (git diff 1fce18d..bbcd69b -> cachyos-fastpath-historical.patch).
    - Document the 3-way merge caveat for pipewire.cpp / stream.cpp.
    - Cross-reference docs/CHANGELOG-SolarFlare.md.

* Also cherry-picked in this batch (already committed locally):
    - 838aa57 build(deps): fix building on Linux with DRM capture disabled (LizardByte#5224)
    - 56d5936 feat(linux/xdgportal): Add support for pipewire-serial (LizardByte#5060)
    - eebb1b0 feat(linux/kwin): log object serial when available on stream creation (LizardByte#5299)
    - 69a2db2 fix(crypto): OpenSSL 4.x compatibility (LizardByte#5330)
  All four were verified to not touch any fork-modified file, so
  cherry-pick was conflict-free.

Verification:
* cmake --build build: success (incremental).
* ./build/tests/test_sunshine: 334 tests, 329 passed (was 328; the
  new upstream test_crypto.cpp added 1 test), 5 pre-existing skipped,
  0 failed. Exit 0.
* bash -n scripts/cachyos-build.sh: OK (post-install verification
  block has valid shell syntax).
* git apply --check cachyos-fastpath.patch on a fresh clone of
  LizardByte/Sunshine HEAD: applies cleanly (0 errors).
* Dependabot: 0 open alerts (still clean from round 2).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants